Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Family Heirloom Tweaks and Various Fixes #498

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

xPokee
Copy link
Contributor

@xPokee xPokee commented Apr 10, 2024

About The Pull Request

  • Removes the detective doll and tragic the garnering decks from the generic heirloom pool
  • Gives every faction a unique heirloom pool
  • Fixes a SINGLE missing pixel on the deathclaw sprite that annoyed me to no end
  • Fixes the R84 LMG spawners spawning the wrong magazine

Let me know in the comments or ping me on discord with other heirloom ideas for faction roles.

Why It's Good For The Game

Redoes an ancient quirk and fixes various things.

Pre-Merge Checklist

  • You tested this on a local server.
  • This code did not runtime during testing.
  • You documented all of your changes.

Changelog

🆑
tweak: tweaked family heirlooms
fix: fixed a single pixel on the deathclaw sprite
fix: fixed R84 LMG spawning weirdly
/:cl:

@xPokee xPokee changed the title Family Heirloom Tweaks Family Heirloom Tweaks and Various Fixes Apr 10, 2024
@CVSthePharmacy
Copy link

please keep the r84 extended mag spawns as so far they are the only gun that allows them to spawn, you can't get extended mags any other way currently.

@xPokee
Copy link
Contributor Author

xPokee commented Apr 11, 2024

please keep the r84 extended mag spawns as so far they are the only gun that allows them to spawn, you can't get extended mags any other way currently.

I'd rather they spawn with the proper ammo type for the gun. Besides I've seen the extended mags spawn in other ammo spawn pools

@xPokee xPokee marked this pull request as ready for review April 11, 2024 14:29
@CVSthePharmacy
Copy link

as of right now they only spawn in the merchant shop due to the r84 lmg

@Yobrocharlie
Copy link
Contributor

Yea if you’re removing the R84 extended rifle may spawn please add it to somewhere else because that is currently the only way to get extended rifle mags outside of beating two of the hardest bunkers.

@CVSthePharmacy
Copy link

maybe making them spawn in r82 spawns

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants